when listing secrets and configmaps, secrets fail with 'V1Secret' object has no attribute 'binary_data'

[ThommyH]

We have a mix of configmaps and secrets for grafana datasources. When the sidecar tries to load the secrets it fails. Neither the configmaps nor the secrets use binary data:

Traceback (most recent call last): File "/app/sidecar.py", line 155, in <module> main() File "/app/sidecar.py", line 113, in main list_resources(label, label_value, target_folder, request_url, request_method, request_payload, File "/app/resources.py", line 128, in list_resources files_changed |= _process_config_map(dest_folder, item, resource, unique_filenames, enable_5xx, True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/app/resources.py", line 217, in _process_config_map if config_map.binary_data is not None: ^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'V1Secret' object has no attribute 'binary_data'

We tried running with the latest version 1.23.1 but that didnt help.

[ThommyH]

I suspect the cleanup method here to be the culprit:

k8s-sidecar/src/resources.py

Line 124 in 062edb9

for key in set(_resources_object_map.keys()) - exist_keys:

It ignores the kind of resources saved in there. Therefore when reaching this line when loading configmaps, it sees the previously added secret and then assumes it is a configmap.

[jekkel]

Thanks for the report, indeed the cleanup code looks broken a bit...

@tomrk-esteam8 could you try fixing that? I think it's a matter of detecting the resource type from item instead. Even extending the test should be easily possible.

[tomrk-esteam8]

@jekkel ok, I will take. a look.

[mario-steinhoff-gcx]

Hey, I fixed this in my local branch, PR will follow shortly.