Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNORE_ALREADY_PROCESSED fails on EKS 1.21 #188

Closed
ccodreanu opened this issue May 24, 2022 · 4 comments · Fixed by #191
Closed

IGNORE_ALREADY_PROCESSED fails on EKS 1.21 #188

ccodreanu opened this issue May 24, 2022 · 4 comments · Fixed by #191
Labels
bug Something isn't working

Comments

@ccodreanu
Copy link

Hi!

I wanted to report an issue with the 1.18.0 version and specifically with the flag in title.

When running on EKS 1.21 the container errors out due to:

Traceback (most recent call last):
  File "/app/sidecar.py", line 142, in <module>
    main()
  File "/app/sidecar.py", line 82, in main
    if int(version.major) > 1 or (int(version.major) == 1 and int(version.minor) >= 19):
ValueError: invalid literal for int() with base 10: '21+'

Thanks!

@jekkel
Copy link
Member

jekkel commented May 24, 2022

@ccodreanu Can you please post the output of

kubectl version --output=yaml

@otchilin You probably want to have look into this?

@jekkel jekkel added the bug Something isn't working label May 24, 2022
@ccodreanu
Copy link
Author

@ccodreanu Can you please post the output of

kubectl version --output=yaml
clientVersion:
  buildDate: "2021-11-17T15:48:33Z"
  compiler: gc
  gitCommit: b695d79d4f967c403a96986f1750a35eb75e75f1
  gitTreeState: clean
  gitVersion: v1.22.4
  goVersion: go1.16.10
  major: "1"
  minor: "22"
  platform: darwin/amd64
serverVersion:
  buildDate: "2022-02-17T16:36:28Z"
  compiler: gc
  gitCommit: eb09fc479c1b2bfcc35c47416efb36f1b9052d58
  gitTreeState: clean
  gitVersion: v1.21.9-eks-0d102a7
  goVersion: go1.16.12
  major: "1"
  minor: 21+
  platform: linux/amd64

@otchilin
Copy link

HI!
Thanks for feedback, I'll fix it by adding a sanity check of version content.

otchilin added a commit to otchilin/k8s-sidecar that referenced this issue May 24, 2022
K8S API version detection reworked to be safer and compatible with non digit major/minor version content.
Only numbers are retained and empty version are rejected.
@jekkel jekkel linked a pull request May 25, 2022 that will close this issue
jekkel added a commit that referenced this issue May 25, 2022
Bug #188 fix. Kubernetes api version detection improved. (#patch)
@jekkel
Copy link
Member

jekkel commented May 25, 2022

@ccodreanu please test with v1.18.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants