Move the unpackFiles step into an AsyncTask

[kollivier]

Right now the loading screen does not show up until loading is actually pretty much complete because all the loading tasks block the UI thread. As a result, you will see a dark grey gradient background instead of the loading screen. For apps with more data to unpack, this can appear for longer and give the impression the app has hung. This is a fix for Issue #983.

[kollivier]

Taking a second look at the code, I think I see why we get the black screen. I was assuming that once the SDL view was loaded, we no longer needed the loading screen, but apparently there's a delay between setting the view and the first actual render. Typically in my own apps I load up my WebView at this point so I didn't notice it. I'm going to run some tests but I bet adding another call to this.setLoadingScreen() right after mActivity.finishLoad() is called should fix it.

[inclement]

I'm just trying some tests, but this seems to be working now, which is great! Just to check, is it ready to merge as far as you are concerned?

[inclement]

Actually, I think this should be mActivity.showLoadingScreen() - I don't know why it worked for me before, but it's crashing now.

[kollivier]

Yeah, I've been using it in my app and so far no issues, just a much nicer initial boot experience. :) In addition, I've gotten an --assets-dir argument working as well (though it's not quite ready for pushing yet), and with the combination there is virtually no hang or startup delay at all! :) From: Alexander Taylor <[email protected]> Reply-To: kivy/python-for-android <[email protected]> Date: Saturday, January 28, 2017 at 12:51 PM To: kivy/python-for-android <[email protected]> Cc: kollivier <[email protected]>, Author <[email protected]> Subject: Re: [kivy/python-for-android] Move the unpackFiles step into an AsyncTask (#990) I'm just trying some tests, but this seems to be working now, which is great! Just to check, is it ready to merge as far as you are concerned? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[kollivier]

Oh sorry, yes, that's correct. It should be mActivity, I thought I had pushed that already... From: Alexander Taylor <[email protected]> Reply-To: kivy/python-for-android <[email protected]> Date: Saturday, January 28, 2017 at 1:09 PM To: kivy/python-for-android <[email protected]> Cc: kollivier <[email protected]>, Author <[email protected]> Subject: Re: [kivy/python-for-android] Move the unpackFiles step into an AsyncTask (#990) @inclement commented on this pull request. In pythonforandroid/bootstraps/sdl2/build/src/org/kivy/android/PythonActivity.java:

+        @OverRide

+        protected void onPostExecute(String result) { +            // Figure out the directory where the game is. If the game was +            // given to us via an intent, then we use the scheme-specific +            // part of that intent to determine the file to launch. We +            // also use the android.txt file to determine the orientation. +            // +            // Otherwise, we use the public data, if we have it, or the +            // private data if we do not. +            mActivity.finishLoad(); + +            // finishLoad called setContentView with the SDL view, which +            // removed the loading screen. However, we still need it to +            // show until the app is ready to render, so pop it back up +            // on top of the SDL view. +            this.showLoadingScreen(); Actually, I think this should be mActivity.showLoadingScreen() - I don't know why it worked for me before, but it's crashing now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[inclement]

Okay, I fixed it locally to test with so I just pushed that. Thanks!

[kollivier]

Cool, thanks! From: Alexander Taylor <[email protected]> Reply-To: kivy/python-for-android <[email protected]> Date: Saturday, January 28, 2017 at 1:16 PM To: kivy/python-for-android <[email protected]> Cc: kollivier <[email protected]>, Author <[email protected]> Subject: Re: [kivy/python-for-android] Move the unpackFiles step into an AsyncTask (#990) Okay, I fixed it locally to test with so I just pushed that. Thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.