Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview improvements #750

Merged
merged 2 commits into from
Jun 18, 2016
Merged

Webview improvements #750

merged 2 commits into from
Jun 18, 2016

Conversation

bobatsar
Copy link
Contributor

Hi there,

here are some improvements to the webview bootstrap:

  • load an url in the webview from python code
  • as in Webview - back button bug #741 described, a second start of the app crashes. At the moment I kill the whole application to make sure the python thread stops. I don't know if this is the best approach but at least it is working.
  • I implemented a handler for the back button to scroll through the browser history and finally close the app. Perhaps this should be made configurable to choose one of the options.
    I am also currently trying to somehow get the back button event via a callback to the python program to handle it there. Do you have a suggestion how to do that? How do you do that in SDL2?

@inclement
Copy link
Member

I'm still not sure about killing the child threads this way, but maybe I should just merge it and leave it to be fixed later.

@inclement
Copy link
Member

I'm not certain if some of this behaviour might need adding to for flexibility, but anyway, great contribution and I'm sorry for the delay merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants