-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 2 updated to version 2.7.9 #678
Conversation
Update from origin master
Thanks for the contribution! I will be away for a few days, and this is a big PR, so we may not have time to look at it for a little while. At a quick glance it looks good though, and we'll take a full look as soon as possible. |
Great work! I haven't got this to work #672.
I found this to be not necessary if using p4a (tested here https://github.com/brussee/SkeletonApp/tree/test2-torrent).
Thanks! I'd like to share the credits with everyone who helped me :) |
I tested this PR for my app (arm, API16, sdl2) and noticed #688 and #689 no longer occur (#690 is still there). You can find it here: https://github.com/brussee/python-for-android/tree/master-PR However, similar to #668, I had to add this to the (python) recipes: numpy, pil, pyasn1, six, zope, android, netifaces, pyjnius, kivy, libtribler, zope_interface.
Otherwise an ELF32 error or Python.h not found occur. |
This isn't a good idea. It makes it harder to use anything which depends on these libs, as everything must now be patched, and it doesn't solve any real problem. The app's libs will be used before system libs. |
@opacam feel free to checkout this commit to undo the changes @kived is talking about brussee@72afe0f Also feel free to checkout that branch to see what I was talking about regarding the recipes. |
version = '2.7.2' | ||
url = 'http://python.org/ftp/python/{version}/Python-{version}.tar.bz2' | ||
version = '2.7.9' | ||
url = 'http://python.org/ftp/python/{version}/Python-{version}.tgz' # tar.bz2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changed to .tgz
? Are the bzip2 archives not distributed anymore? bzip2 should be preferred as it is a smaller download at the expense of slower extraction - but people are far more likely to have download caps than execution caps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the package no longer exist in *.bz2 compression for this version of python, only exist in *.tgz format...
Why not go for 2.7.11 directly? |
Oooo...that's a point!!! but I made this recipe a long time ago (with the old toolchain) and I recently migrated to the new toolchain...going to the new python 2.7.11 will require more work to do and that is not an easy task (despite I think it must be done at some point) but for now this version is enough to solve some security issues related with the requests module that can not be solved with the old python version (at least I cannot solve) and this recipe is working (it's building and running fine) Also notice that the current python version (2.7.2) distributed with the python-for android is running since I can remember (at least 2 years...or more) and it is really outdated, and I know that some user tried to update the python version for the old toolchain without success (sorry...I don't remember who), so... I think that this is a first step into the future. |
# Conflicts: # pythonforandroid/recipes/python2/__init__.py
Successfully build with last changes applied and with command: python-for-android create --dist_name=test_sdl2 --bootstrap=sdl2 --requirements=hostpython2,libffi,openssl,sqlite3,python2,pil,kivy Notice that hostpython, and python must be build with the right order when using sdl2 bootstrap and using sqlite3 recipe, otherwise it will fail to build because the build order is not correct (this is not happening when using the pygame bootstrap)...Maybe is a bug when checking optional dependencies? |
Ok... now we are on the road...I think that all the proposed changes are been done Note: Tested with sdl2 bootstrap |
Now I'm doing some test with the last python version (2.7.11) ... and it's working...so this will be closed and I will make a new Pull Request with the new version when I have all in order. Thanks to all who take his time to see this pull request...hope I see you soon when i make the new pull request for the last version of python |
This is my first contribution to github... so be gentle with me if I do something wrong (I hope not)
This recipe has been tested with my android application, in fact, this is a migrated version from the python-for-android old toolchain, so... this works for me (it has been tested, with the new toolchain, as a local recipe and installed on a device running android version 4.0.4)
Notes: