Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenSSL version to 1.1.1w #2958

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Update OpenSSL version to 1.1.1w #2958

merged 1 commit into from
Jan 21, 2024

Conversation

prolenodev
Copy link
Contributor

I encountered the following error:

Downloading openssl from https://www.openssl.org/source/openssl-1.1.1m.tar.gz
resulted in
urllib.error.HTTPError: HTTP Error 404: Not Found
and a failed build.

On visiting the link from the old code, it says

Page Not Found
Sorry, but the link you gave does not exist.

The download for old version has been moved to https://www.openssl.org/source/old/1.1.1/openssl-1.1.1m.tar.gz
The link for the latest version is https://www.openssl.org/source/openssl-1.1.1w.tar.gz

This commit includes the updated link to resolve the above error.

@brentpicasso
Copy link
Contributor

I just ran into this problem too. +1 for getting this merged. And thank you for submitting the PR!

@misl6
Copy link
Member

misl6 commented Jan 21, 2024

I guess we need a new release.

@misl6 misl6 changed the title Update OpenSSL version to 1.1.1w Update OpenSSL version to 1.1.1w Jan 21, 2024
@TechLearner18
Copy link

TechLearner18 commented Jan 21, 2024

Is there a way to specify openssl==1.1.1w in the build spec? Tried it in buildozer.spec but not working.
Also tried brew install openssl which updated the latest version, but the build still tries to pull 1.1.1m

Update:
I made a local recipe and it's working now. Followed the steps here
https://github.com/Android-for-Python/Android-for-Python-Users?tab=readme-ov-file#appendix-c--locally-modifying-a-recipe

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

(CI/CD pipeline took a while)

@misl6 misl6 merged commit 4dcb61e into kivy:develop Jan 21, 2024
33 checks passed
@coquepas
Copy link

coquepas commented Jan 21, 2024

hi! is it possible to cherrypick this change also into the "release-2022.12.20" branch? it's the only release that works for me ^.^

@HeaTTheatR
Copy link

Unfortunately, it doesn't work for me. P4A continues to download openssl-1.1.1m.tar.gz

@TechLearner18
Copy link

Unfortunately, it doesn't work for me. P4A continues to download openssl-1.1.1m.tar.gz

Did you try local recipe as mentioned in the above link?

@TechLearner18
Copy link

hi! is it possible to cherrypick this change also into the "release-2022.12.20" branch? it's the only release that works for me ^.^

Try the openssl recipe as per the above link

@HeaTTheatR
Copy link

@TechLearner18 Yes:

[...]

requirements = openssl==1.1.1w, ...
p4a.branch = master

[...]

@TechLearner18
Copy link

@TechLearner18 Yes:

[...]

requirements = openssl==1.1.1w, ...
p4a.branch = master

[...]

that wont work. Download as per the link and just copy the openssl folder. make the changes in the init.py
Set p4a.local_recipes = ./p4a-recipes in the buildozer.spec. Dont forget to run buildozer appclean

@HeaTTheatR
Copy link

I had to manually change the OpenSSL version in the recipe

@kuzeyron
Copy link
Contributor

I had to manually change the OpenSSL version in the recipe

Change the branch to develop and clean before you compile it again.

@coquepas
Copy link

hi! is it possible to cherrypick this change also into the "release-2022.12.20" branch? it's the only release that works for me ^.^

Try the openssl recipe as per the above link

Yep, works fine doing that :)

@Sebastian-Lizard
Copy link

Estou gerando apk apartir do google colab e também aparece o mesmo erro, coloquei o link mais recente no requirements (buildozer.spec) mas continua dar o mesmo erro!!!

@brentpicasso
Copy link
Contributor

Hi, when can we expect a new release with this fix?

@misl6
Copy link
Member

misl6 commented Jan 23, 2024

Hi, when can we expect a new release with this fix?

The new release is out now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants