Include paths for sdl2_mixer have changed. Added a method to return the right one. #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
AndreMiras
previously approved these changes
Nov 5, 2022
misl6
force-pushed
the
fix/sdl2-mixer-include-dirs
branch
from
6f3e2d4 to
53cf0e5
Compare
shyamnathp
pushed a commit
to shyamnathp/python-for-android
that referenced
this pull request
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #2698
Include paths for
sdl2_mixerchanged recently, so recipes (likeffpyplayer) that were using a hardcoded path are failing to build.get_include_dirsmethod (like the one we have inlibffi), forsdl2_mixer.get_include_dirsmethod.