Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version of pygame from 2.0.1 to 2.1.0 #2520

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Updated version of pygame from 2.0.1 to 2.1.0 #2520

merged 1 commit into from
Nov 29, 2021

Conversation

captain0xff
Copy link
Contributor

Changed the version of pygame in the recipe from 2.0.1 (released in Dec 2020) to the latest release 2.1.0 (released in Nov 2021).

Changed the version of pygame in the recipe from 2.0.1 (released in Dec 2020) to the latest release 2.1.0 (released in Nov 2021).
@misl6
Copy link
Member

misl6 commented Nov 20, 2021

@CAPTAIN1947
Did you had the chance to test it on runtime?

@captain0xff
Copy link
Contributor Author

@CAPTAIN1947 Did you had the chance to test it on runtime?

@misl6
Yes I tried a few games and examples and they were working fine with 2.1.0.
But I only tested by specifically specifying the version 2.1.0 in the buildozer.spec.
I also took permission from the pygame devs and they said that its ok as 2.1.0 has a lot of changes (the support for python2 and sdl1 is dropped) and it's good if the version is updated.

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I didn't have the chance to test it on runtime but looks good, and you posted some additional useful info.

I don't immediately merge it, but I will schedule a follow-up for the next week, so if meanwhile someone shows up and has an additional test case, we can hear another opinion about it.

@misl6 misl6 merged commit dea23e8 into kivy:develop Nov 29, 2021
@captain0xff
Copy link
Contributor Author

Thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants