Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pymunk crash on older versions of Android #2399

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Fix Pymunk crash on older versions of Android #2399

merged 1 commit into from
Jan 5, 2021

Conversation

viblo
Copy link
Contributor

@viblo viblo commented Jan 3, 2021

Seems to be required to link -lm on at least 5.1, but not on 8.0.
Should fix #2388

@viblo
Fix Pymunk crash on older versions of Android
210a1a2 
Seems to be required to link -lm on at least 5.1, but not on 8.0
@viblo viblo mentioned this pull request Jan 3, 2021
Closed
@Sahil-pixel
Copy link
Contributor

def get_recipe_env(self, arch):
env = super().get_recipe_env(arch)
env["LDFLAGS"] += " -llog"
env["LDFLAGS"] += " -llog" # Used by Chipmunk cpMessage
env["LDFLAGS"] += " -lm" # For older versions of Android
return env

Great.. Now this is working in Android 5.1

AndreMiras
AndreMiras approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@AndreMiras AndreMiras merged commit 929d727 into kivy:develop Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pymunk,kivy apk crashing on Android 5.1
3 participants
@viblo @Sahil-pixel @AndreMiras