Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modifications for ndk >= r22 #2393

Closed
wants to merge 1 commit into from
Closed

modifications for ndk >= r22 #2393

wants to merge 1 commit into from

Conversation

obfusk
Copy link
Contributor

@obfusk obfusk commented Jan 2, 2021 •
edited
Loading

  • ndk >= r22 no longer supports
    • {ndk_dir}/platform
    • {ndk_dir}/sysroot
  • add & use
    • ctx.ndk_standalone
    • ctx.ndk_sysroot
    • ctx.ndk_lib_dir
    • ctx.ndk_include_dir
  • patch openssl
  • add FIXMEs to some recipes
    • nothing should have changed for ndk < r22
    • modifications and/or testing may be needed for ndk >= r22
  • CI: mark some packages as broken

Fixes #2391

  • "Works for me" 😅
  • Needs a review & probably some tests :)

@obfusk obfusk force-pushed the ndk-22 branch 10 times, most recently from 379687a to 3583f21 Compare January 2, 2021 03:26
@obfusk obfusk mentioned this pull request Jan 2, 2021
Merged
3 tasks
@obfusk obfusk marked this pull request as ready for review January 2, 2021 13:39
@obfusk
Copy link
Contributor Author

obfusk commented Jan 3, 2021 •
edited
Loading

[edit: fixed]

@obfusk
Copy link
Contributor Author

obfusk commented Jan 5, 2021

It "works for me" 😅 and I don't think these modifications would impact anyone not using ndk >= r22 (which doesn't work without these changes anyway), so I think this can be merged (assuming CI agrees with me).

Adding a CI run w/ ndk r22 would be nice though.

@obfusk
modifications for ndk >= r22
39f5f51 
* ndk >= r22 no longer supports
  - {ndk_dir}/platform
  - {ndk_dir}/sysroot
* add & use
  - ctx.ndk_standalone
  - ctx.ndk_sysroot
  - ctx.ndk_lib_dir
  - ctx.ndk_include_dir
* patch openssl
* add FIXMEs to some recipes
  - nothing should have changed for ndk < r22
  - modifications and/or testing may be needed for ndk >= r22
* CI: mark some packages as broken
@obfusk obfusk changed the title rework platform & sysroot usage for ndk >= r22 modifications for ndk >= r22 Jan 6, 2021
@obfusk
Copy link
Contributor Author

obfusk commented Jan 6, 2021

CI was happy, so I rebased & squashed.

@obfusk
Copy link
Contributor Author

obfusk commented Mar 5, 2021

I'd appreciate some feedback on this (if someone has the time) :)

@misl6
Copy link
Member

misl6 commented Nov 20, 2021

Can you confirm that with latest develop branch this PR is now un-needed? (At least in part)

@misl6
Copy link
Member

misl6 commented Apr 8, 2022

NDK 23b is now the default supported version, I'm closing this PR as is now outdated.

Maybe you would like to try the latest changes on develop?

Thank you for taking care of python-for-android!

@misl6 misl6 closed this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-reply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

p4a is not compatible with ndk >= 22
2 participants
@obfusk @misl6