Audiostream Fix #2375
Merged
Audiostream Fix #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've rebased this PR to clean #2376 out of it, and updated it to reference the master branch for audiostream now that kivy/audiostream#34 has been merged. I took the time to put the commit hash in and add its checksum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix kivy/audiostream#25 . Previously using audiostream caused a crash when loading.
It looks like audiostream hasn't been maintained much. Is it still the best route for accessing audio in a platform independent way on kivy?
EDIT: it looks like a commit from master got into my PR because it's missing from develop; I'm thinking you probably want that on the develop branch too.