Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix travis #2279

Merged
merged 1 commit into from
Aug 5, 2020
Merged

fix travis #2279

merged 1 commit into from
Aug 5, 2020

Conversation

obfusk
Copy link
Contributor

@obfusk obfusk commented Aug 4, 2020

No description provided.

@obfusk obfusk marked this pull request as ready for review August 4, 2020 08:13
@obfusk
Copy link
Contributor Author

obfusk commented Aug 4, 2020

Ironically, one of the builds timed out downloading sqlite3. Seems to be fine otherwise.

AndreMiras
AndreMiras previously approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.
Could you simply remove the debugging code (ls and which).
As for the macOS build time out yes that's very weird, it's started acting like so a couple of month ago and I didn't get a chance to investigate really

@obfusk
Copy link
Contributor Author

obfusk commented Aug 4, 2020

Could you simply remove the debugging code (ls and which).

I left it in intentionally so it would be easier to fix if the version changes again. But I can remove it of course.

@AndreMiras
Copy link
Member

Yes I'd rather remove it indeed

@obfusk
Copy link
Contributor Author

obfusk commented Aug 5, 2020

Removed.

AndreMiras
AndreMiras approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and thanks for the squash, I appreciate :)

@AndreMiras AndreMiras merged commit 29a79c5 into kivy:develop Aug 5, 2020
@AndreMiras
Copy link
Member

Re the macOS build, we may want to create a tech debt task and disable only the macOS build until this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obfusk @AndreMiras