Support for native services #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerela
force-pushed
the
native_services_upstream
branch
from
1921654 to
336c636
Compare
AndreMiras
approved these changes
Aug 14, 2020
| @@ -619,6 +620,9 @@ def parse_args_and_make_package(args=None): | |||
| ap.add_argument('--service', dest='services', action='append', default=[], | |||
| help='Declare a new service entrypoint: ' | |||
| 'NAME:PATH_TO_PY[:foreground]') | |||
| ap.add_argument('--native-service', dest='native_services', action='append', default=[], | |||
| help='Declare a new native service: ' | |||
| 'package.name.service') | |||
There was a problem hiding this comment.
Minor: no sure why this line is broken down in two
There was a problem hiding this comment.
No specific reason, I just used the same codestyle than for the previous argument (line 620/621) for consistency.
Thanks for the merge!
|
Was it intentional to merge this into |
|
ow, probably an overlook! |
|
Ah, that's my mistake, GitHub didn't pick the default branch when I created the PR therefore it targeted |
|
ouch I completely missed that 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2243