Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated gradle plugin version #2234

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Updated gradle plugin version #2234

merged 1 commit into from
Dec 28, 2020

Conversation

shashi278
Copy link
Contributor

@shashi278 shashi278 commented Jun 8, 2020

Description of changes:

  • 3.1.4 seems to be pretty outdated and also has some issues with Firebase, 3.5.2 works quite well.
  • Got rid of deprecated compile method. Replaced them with implementation.
    * Added extra classpath and apply plugin as they're required to use firebase(Instead of hardcoding these in the build.gradle file, there could be options to add extra classpath and apply plugin as per one's requirement). (Because Google services plugin requires a google-services.json file so this plugin must only be added if requires)

Got rid of deprecated compile method
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI happy so we should be fine, thanks

@AndreMiras AndreMiras merged commit f2fff78 into kivy:develop Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants