-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup.py: add classifiers & python_requires #2151
Conversation
setup.py
Outdated
@@ -88,6 +88,7 @@ def recursively_include(results, directory, patterns): | |||
description='Android APK packager for Python scripts and apps', | |||
long_description=long_description, | |||
long_description_content_type='text/markdown', | |||
python_requires="==3.*,>=3.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just curious isn't this redundant? Don't we only need python_requires="==3.*,>=3.6.0"
.
If you added it in case of Python 4, I would say keep it simple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for a while we also didn't have it as like Django is doing, you still want to have people from Python2 to see this package when pip search-ing or pip install-ing, so then we can display an explicit message saying Python 2 is not supported.
See https://github.com/django/django/blob/3.0.5/setup.py tell me if it makes sense to you?
Mmmm...interesting...I did some research... I think that pip search doesn't care about python version...for instance...I maintain a Python3 only package, never compatible with Python2. This project is named
And if you try to install a python3 only package, using the branch of this PR:
|
I think pip do care when searching and your project didn't have the Python classifier on the setup so I think that's why it appeared https://github.com/opacam/Cohen3/blob/0.8.0/setup.py |
No description provided.