Fix some code quality and bug-risk issues #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnijhara
force-pushed
the
pnijhara-patch-1
branch
from
c676b0b to
e97e6cf
Compare
pnijhara
force-pushed
the
pnijhara-patch-1
branch
from
e97e6cf to
00719ae
Compare
AndreMiras
reviewed
Apr 17, 2020
| @@ -894,7 +894,9 @@ def biglink(ctx, arch): | |||
| env=env) | |||
|
|
|||
|
|
|||
| def biglink_function(soname, objs_paths, extra_link_dirs=[], env=None): | |||
| def biglink_function(soname, objs_paths, extra_link_dirs=None, env=None): | |||
There was a problem hiding this comment.
Special thanks for this change :) default mutable argument gotcha 👍
AndreMiras
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find the other issues found here - https://deepsource.io/gh/pnijhara/python-for-android/issues/?category=all
This PR also adds
.deepsource.tomlconfiguration file to run DeepSource analysis on the repo with. Upon enabling DeepSource, the analysis will run on every PR and commit to detect 560+ types of issues in the changes — including bug risks, anti-patterns, security vulnerabilities, etc.To enable DeepSource analysis after merging this PR, please follow these steps:
You can also look at the docs for more details. Do let me know if I can be of any help!