-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto deploys to PyPI using Travis on tags #2122
Conversation
Prior to this change, I made a test setting a version already deployed (
I also temporarily changed the |
Build fail with openssl download issue:
I will rebase to #2121 once it's merged to develop |
Uses PyPI `__token__` and Travis auto deployment to publish to PyPI upon tagging. https://pypi.org/help/#apitoken Travis uses the not so well documented `PYPI_PASSWORD` environment variable to store the password. https://github.com/travis-ci/dpl/blob/v1.10.15/lib/dpl/provider/pypi.rb#L12 The variable was set with a valid token prior this change. https://travis-ci.org/github/kivy/python-for-android/settings This is more secure than user and password as tokens are generated with uploaded only permissions and can be scoped to a given project.
8e079af
to
266cfc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR!! 👍
Just wondering, why not do this with github actions?
I know, that travis it has been around for a while, and is pretty well tested, but one great thing about github actions, is that you can split the logic into multiple files, so in a long term, I think is more maintainable. Is it possible to do similar thing with travis?
Thanks for the review! Yes that's basically it for Travis, the setup was easy and I got it working in the past, so it was slightly less headaches. Also one thing I'm really missing with github action is being able to restart just one job rather than the full workflow. |
Yes, you are right, restart all the jobs is not ideal, but with a separate workflow for the |
Uses PyPI
__token__
and Travis auto deployment to publish to PyPIupon tagging.
https://pypi.org/help/#apitoken
Travis uses the not so well documented
PYPI_PASSWORD
environmentvariable to store the password.
https://github.com/travis-ci/dpl/blob/v1.10.15/lib/dpl/provider/pypi.rb#L12
The variable was set with a valid token prior this change.
https://travis-ci.org/github/kivy/python-for-android/settings
This is more secure than user and password as tokens are generated with
uploaded only permissions and can be scoped to a given project.