📦 Refactor python module into hostpython3/python3 recipes #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opacam
force-pushed
the
feature-refactor-python
branch
from
0fb6df5 to
94afa5b
Compare
As it was done originally because with only one python recipe, there is no need to have a subclass.
opacam
force-pushed
the
feature-refactor-python
branch
from
94afa5b to
e442905
Compare
inclement
approved these changes
Mar 30, 2020
zworkb
pushed a commit
to zworkb/python-for-android
that referenced
this pull request
Apr 15, 2020
* 📦 Refactor `pythonforandroid.python` recipes into his own recipe As it was done originally because with only one python recipe, there is no need to have a subclass. * ✅ Update tests to work with refactored `python3` recipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we had it this way before we have multiple python recipes, but with #2105 merged, there is no point to have subclasses for the python recipe. Also we will have the code of the deleted
pythonmodule split into two recipes (hostpython3andpython3recipes) which, imho, will improve the readability.Notes:
supercalls #2106, so I do not recommend to merge this before 🔥 Move to python3supercalls #2106