Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numpy to v1.18.1 (add cython recipe) #2077

Merged
merged 3 commits into from
Mar 14, 2020

Conversation

opacam
Copy link
Member

@opacam opacam commented Mar 2, 2020

We add the cython recipe because the last version of numpy (at time of writing v1.18.1), requires cython installed as a Python module during the build stage of the numpy recipe.

Also this will make the numpy recipe only available for Python3 since it requires python>=3.5.

@opacam
Copy link
Member Author

opacam commented Mar 2, 2020

Seems that the new numpy recipe is also failing for MacOs...similar error as the old numpy version tested at #2046 (see this comment)...anyway I just wanted to test in here, imho, it is not a good idea rely such test on MacOs build, so I will move it.

Note:: Just noting that this cannot break what is already broken, but we still will lose numpy for Python2...well...I don't think that this fact is so important considering that it won't be maintained anymore...we should remove it, probably sooner than later

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opacam opacam merged commit 9d5ebb6 into kivy:develop Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants