Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on py2 when import numpy #2003

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

opacam
Copy link
Member

@opacam opacam commented Oct 14, 2019

Also:

  • make use of python3 super() for numpy recipe

Closes: #1988

Also:
  - make use of python3 `super()` for numpy recipe
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks
Even though it often hurts me to see time/effort spent on Python2 specific. That actually deserves a won't fix to incentive users to move to target Python3 as well

@opacam
Copy link
Member Author

opacam commented Oct 14, 2019

Aaa.. you are right @AndreMiras, people should move to python3, but we still have python2 in here, so I have the feeling that we should give a solution, or we will fill p4a issues about the same error, anyway feel free to merge this yourself or close it I give this to your judgement 😉

@AndreMiras AndreMiras merged commit f8472bd into kivy:develop Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing numpy yields: TypeError: add_docstring() argument 2 must be str, not None
2 participants