Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setuptools to Kivy recipe requirements #1938

Merged
merged 1 commit into from
Jul 28, 2019

Conversation

inclement
Copy link
Member

Kivy master (and future Kivy releases) depends on setuptools now, whereas it didn't before. I think we should just add it to the requirements now, to avoid issues when people try to install from master. It doesn't seem worth messing around with making setuptools a requirement only if Kivy > 1.11 is being targeted.

Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Thanks @inclement!!

Note: There is no need to add this dependency in the current state of p4a because setuptools will be indirectly installed (see comment). Still it may be worth it to add setupttools as a kivy dependency... for reference and to avoid possible future changes.

@inclement
Copy link
Member Author

Thanks @opacam. I saw that comment, but I didn't realise that setuptools is effectively a default dependency now. I've seen a user have issues using p4a master, but in this case it looks like they were probably using an older version of p4a where this dependency chain wasn't the same.

@inclement inclement merged commit 0e8e945 into kivy:develop Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants