-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple run_pymodules_install test, refs #1898 #1899
Merged
inclement
merged 1 commit into
kivy:develop
from
AndreMiras:feature/ticket1898_run_pymodules_install_regression_test
Jun 29, 2019
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import unittest | ||
|
||
try: | ||
from unittest import mock | ||
except ImportError: | ||
# `Python 2` or lower than `Python 3.3` does not | ||
# have the `unittest.mock` module built-in | ||
import mock | ||
from pythonforandroid.build import run_pymodules_install | ||
|
||
|
||
class TestBuildBasic(unittest.TestCase): | ||
|
||
def test_run_pymodules_install_optional_project_dir(self): | ||
""" | ||
Makes sure the `run_pymodules_install()` doesn't crash when the | ||
`project_dir` optional parameter is None, refs #1898 | ||
""" | ||
ctx = mock.Mock() | ||
modules = [] | ||
project_dir = None | ||
with mock.patch('pythonforandroid.build.info') as m_info: | ||
assert run_pymodules_install(ctx, modules, project_dir) is None | ||
assert m_info.call_args_list[-1] == mock.call( | ||
'No Python modules and no setup.py to process, skipping') |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reminds me we still need to decide when p4a drops python2 support. Soon would probably be good, it's especially annoying nowadays to do python2 compatibility stuff when it will be necessary for only a short time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely agree. Also I can't wait to use f-strings and annotations :smile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm also waiting for python 3's
f-strings
, but this will requirepython >= 3.6
...I have no problem with thatAs a side note: we could already use python 3
f-strings
but now it would require the install of some extra python package like fmt (I've been tempted of doing this in some prs 😆)