Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kivy] updated to 44a8a6f #1777

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Conversation

goffi-contrib
Copy link
Contributor

No description provided.

@@ -7,7 +7,7 @@

class KivyRecipe(CythonRecipe):
# post kivy==1.10.1, `fixes SDL2 image loading (jpg)`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this comment is not accurate anymore, would you mind updating?

@AndreMiras
Copy link
Member

Thanks for the pull request!
Could you make it clear in your commit title or body why is this update needed, what does it fix? I remember we talked about it on the chat, but having it in the commit history is even more important I think

This revision seems to not crash anymore when orientation is changed
using `user` or `fullUser` orientation mode.
@goffi-contrib
Copy link
Contributor Author

@AndreMiras sure, I've just updated it.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@AndreMiras AndreMiras merged commit 16d4d29 into kivy:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants