Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cryptography] updated to 2.6.1 #1761

Merged
merged 1 commit into from
Mar 17, 2019

Conversation

goffi-contrib
Copy link
Contributor

No description provided.

@AndreMiras
Copy link
Member

AndreMiras commented Mar 16, 2019

LGTM, but conditional build is failing. I think it's time to add libssl-dev dependency to our Docker image.
Could you add the dep to that line https://github.com/kivy/python-for-android/blob/9736243/Dockerfile.py3#L114 for instance?

I assumed this is why it was failing, but I'm giving a try locally now and it seems to still fail on Docker even with that system dependency. I'll take a further look soon

@AndreMiras AndreMiras self-assigned this Mar 16, 2019
@AndreMiras
Copy link
Member

So it should actually reference to the local openssl recipe and for some reason it doesn't.
If I compile openssl recipe explicitly first then it works, otherwise it doesn't seem to properly reference to it. I'd like to investigate further

@AndreMiras
Copy link
Member

So it looks like a bug with the dependency resolution, we'll be tracking it here #1764

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so after investigating it's because we need our conditional recipe build to use testapps/setup_testapp_python3_sqlite_openssl.py rather than testapps/setup_testapp_python3.py.
So @goffi-contrib would you mind updating ci/rebuild_updated_recipes.py and replace setup_testapp_python3.py by setup_testapp_python3_sqlite_openssl.py?

also updated `ci/rebuild_updated_recipes.py` to pass the tests (cf. kivy#1761 (review))
@goffi-contrib goffi-contrib force-pushed the cryptography_update_2.6.1 branch from a8b4c7a to 9b468a5 Compare March 17, 2019 09:57
@goffi-contrib
Copy link
Contributor Author

@AndreMiras done

@AndreMiras AndreMiras merged commit bc41b50 into kivy:master Mar 17, 2019
@AndreMiras
Copy link
Member

Awesome work, it builds now. I've merged it, can you rebase your other pull requests on master so we have that fix in place?
By the way thanks for always squashing your commits 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants