-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cryptography] updated to 2.6.1 #1761
[cryptography] updated to 2.6.1 #1761
Conversation
LGTM, but conditional build is failing. I think it's time to add I assumed this is why it was failing, but I'm giving a try locally now and it seems to still fail on Docker even with that system dependency. I'll take a further look soon |
So it should actually reference to the local |
So it looks like a bug with the dependency resolution, we'll be tracking it here #1764 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so after investigating it's because we need our conditional recipe build to use testapps/setup_testapp_python3_sqlite_openssl.py
rather than testapps/setup_testapp_python3.py
.
So @goffi-contrib would you mind updating ci/rebuild_updated_recipes.py and replace setup_testapp_python3.py
by setup_testapp_python3_sqlite_openssl.py
?
also updated `ci/rebuild_updated_recipes.py` to pass the tests (cf. kivy#1761 (review))
a8b4c7a
to
9b468a5
Compare
@AndreMiras done |
Awesome work, it builds now. I've merged it, can you rebase your other pull requests on master so we have that fix in place? |
No description provided.