-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xeddsa] fixed shared library copying #1756
[xeddsa] fixed shared library copying #1756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for antoher pull request!
Same here I'd like to investigate myself why it's failing to build in the CI before merging:
�[1m[INFO]�[0m: �[90m->�[0m running cp _crypto_sign.so /home/user/.local/share/python-...(and 61 more)�[0m
Exception in thread background thread for pid 7794:
Traceback (most recent call last):
File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner
self.run()
File "/usr/lib/python3.6/threading.py", line 864, in run
self._target(*self._args, **self._kwargs)
File "/home/user/venv/lib/python3.6/site-packages/sh.py", line 1540, in wrap
fn(*args, **kwargs)
File "/home/user/venv/lib/python3.6/site-packages/sh.py", line 2459, in background_thread
handle_exit_code(exit_code)
File "/home/user/venv/lib/python3.6/site-packages/sh.py", line 2157, in fn
return self.command.handle_command_exit_code(exit_code)
File "/home/user/venv/lib/python3.6/site-packages/sh.py", line 815, in handle_command_exit_code
raise exc
sh.ErrorReturnCode_1:
RAN: /bin/cp _crypto_sign.so /home/user/.local/share/python-for-android/build/python-installs/bdisttest_python3_googlendk
STDOUT:
/bin/cp: cannot stat '_crypto_sign.so': No such file or directory
80b7926
to
f6cdc64
Compare
The copy of the build shared library was not working anymore after the update of python2 build chain. This patch fixes it by using self.ctx.get_site_packages_dir().
f6cdc64
to
2a1944f
Compare
It still seems to be failing with that same |
@AndreMiras yes it does work for me locally. Would be nice if you could have a look indeed, thanks :) |
OK I've played with it in Docker.
So the library actually is |
Could be `_crypto_sign.cpython-37m-x86_64-linux-gnu.so` or simply `_crypto_sign.so` depending on the platform/distribution
Conditional recipe build is green https://travis-ci.org/kivy/python-for-android/jobs/512985553 |
The copy of the build shared library was not working anymore after the
update of python2 build chain. This patch fixes it by using
self.ctx.get_site_packages_dir().