Fix sdl2_image compile error when arch is x86 #1718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building an apk with
--bootstrap=sdl2
and--arch=x86
breaks due to failingpythonforandroid/recipes/sdl2_image/disable_jpg.patch
. This error is minor regression of #1692 wheredisable_jpg.patch
was not upgraded for SDL2_image 2.0.4.Fix
I think this
disable_jpg.patch
is a legacy that was introduced when multi-arch support was being added to the project (f8eb278); andwe can safely void it now(I guess it would be the best toask for a comment from @inclement ). (I tested compiling without this patch for
x86
and everything works fine including runtime tests.)