Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setenv() of non-SDL2 bootstrap #1714

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

j-devel
Copy link
Contributor

@j-devel j-devel commented Feb 18, 2019

Fixes #1702. This is regression related to #1690. For non-SDL2 bootstrap, we should not use SDL_setenv() here; instead, use the plain setenv() as previously. Sorry that I missed testing this bootstrap case.

Before fix:

/home/a/.local/share/python-for-android/build/bootstrap_builds/webview-python2/jni/application/src/start.c:471: error: undefined reference to 'SDL_setenv'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

After fix: No compile errors regarding this issue.

@AndreMiras
Copy link
Member

Yes we definitely need some runtime automated testing. Thank you for addressing that regression!

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AndreMiras AndreMiras merged commit 1db60cf into kivy:master Feb 18, 2019
@j-devel j-devel deleted the fix-setenv-webview-non-sdl2 branch February 18, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webview build can't find SDL_setenv.
2 participants