Added warning for arguments containing carriage returns. This happens… #1712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… if a shell script was written in Windows but executed in Linux, as may be the case with bash for Windows.
Example of undefined behaviour:
--requirements=python3,kivy,numpy
, which causes the last package to benumpy\r
due to the CRLF at the end of the line. This might get through to pip but not have any associated p4a recipes, leading to many red herrings and wild goose chases.The solution to this was straightforward (change my text editor to use LF instad of CRLF), but this behaviour was difficult and time-consuming to debug. Although this problem is not due to python-for-android, I decided to open this PR regardless as it would improve developer quality of life.