Speed up Docker chown via COPY parameter #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
changed the title
For some reason running the `chown` command explicitly is hanging on
Docker. Using the `--chown` parameter in the `COPY` command is faster.
However that new method has a couple of drawbacks:
1) it was introduced in a recent Docker version 17+
2) it doesn't accept variables as argument, only hardcoded values
Unfortunately we still need to use explicit "shell" `chown` for the
`ANDROID_SDK_HOME` as this directory must still be writable. Error was:
```
A problem occurred configuring root project 'bdisttest_python2'.
> Failed to install the following SDK components:
build-tools;27.0.3 Android SDK Build-Tools 27.0.3
The SDK directory is not writable (/opt/android/android-sdk)
```
AndreMiras
force-pushed
the
feature/speedup_docker_chown
branch
from
c0ce667 to
093b206
Compare
inclement
approved these changes
Feb 1, 2019
AndreMiras
changed the title
|
Build is green 🎊 merging |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason running the
chowncommand explicitly is hanging onDocker. Using the
--chownparameter in theCOPYcommand is faster.However that new method has a couple of drawbacks:
Also note that we don't need to chmod
ANDROID_SDK_HOMEanymore.