Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up Python and NumPy compilation process #1651

Merged

Conversation

AndreMiras
Copy link
Member

Uses -j flag on target/host python as well as numpy to run compilation
in parallel. In Python an optimum number of jobs is guessed if the flag
is used alone. In NumPy it must be explicitly set.

@AndreMiras AndreMiras requested a review from inclement February 1, 2019 02:35
@AndreMiras AndreMiras force-pushed the feature/python_build_parallel_jobs branch from cc379cd to 79d23ed Compare February 1, 2019 02:58
pythonforandroid/python.py Outdated Show resolved Hide resolved
pythonforandroid/python.py Outdated Show resolved Hide resolved
Uses `-j` flag on target/host python as well as numpy to run compilation
in parallel.
In NumPy we need to revert the `setup_extra_args` value so it doesn't
mess up with subsequent calls, e.g. `python setup.py install`.
@AndreMiras AndreMiras force-pushed the feature/python_build_parallel_jobs branch from 79d23ed to b4a6a66 Compare February 1, 2019 11:00
Copy link
Member Author

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR with explicit jobs count via cpu_count()

@inclement inclement merged commit 015c0eb into kivy:master Feb 1, 2019
@AndreMiras AndreMiras deleted the feature/python_build_parallel_jobs branch February 1, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants