Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set $LANG in PythonRecipe #1642

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

inclement
Copy link
Member

Seems pretty benign so no reason not to do it.

Fixes #703.

@inclement inclement requested a review from AndreMiras January 31, 2019 17:12
@@ -764,6 +764,10 @@ def get_recipe_env(self, arch=None, with_flags_in_cc=True):

env['PYTHONNOUSERSITE'] = '1'

# Set the LANG, this isn't usually important but is a better default
# as it occasionally matters how Python e.g. reads files
env['LANG'] = "en_GB.UTF-8"
Copy link
Member

@AndreMiras AndreMiras Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not en_US.UTF-8 :trollface:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually copied it from #703 and didn't even read it :p

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge once Travis is happy

@inclement inclement merged commit 2cc008b into kivy:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants