Conditional build script fixes #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AndreMiras
commented
Jan 20, 2019
AndreMiras
commented
- explicitly sets default target python3 to build order
- uses logger rather than print
- updates libzbar recipe to demo python2 fallback (E126 lint fix)
AndreMiras
commented
Jan 20, 2019
| if target_python.name not in build_order: | ||
| print('incompatible with {}'.format(target_python.name)) | ||
| # forces the default target | ||
| recipes_and_target = recipes | set([target_python.name]) |
There was a problem hiding this comment.
AndreMiras
commented
Jan 20, 2019
| @@ -17,7 +17,7 @@ class LibZBarRecipe(Recipe): | |||
|
|
|||
| def should_build(self, arch): | |||
| return not os.path.exists( | |||
| os.path.join(self.ctx.get_libs_dir(arch.arch), 'libzbar.so')) | |||
| os.path.join(self.ctx.get_libs_dir(arch.arch), 'libzbar.so')) | |||
There was a problem hiding this comment.
Minor E126 lint fix to demonstrate conditional recipe rebuild.
The libzbar recipe is currently python2 only so the conditional build script should first try with current default target python3 and then fallback to python2
- explicitly sets default target python3 to build order - uses logger rather than print - updates libzbar recipe to demo python2 fallback (E126 lint fix)
AndreMiras
force-pushed
the
feature/conditional_build_improvements
branch
from
55a5cf0 to
92fde71
Compare
|
Conditional build successfully, see log https://travis-ci.org/kivy/python-for-android/jobs/482167490 Ready for the merge |
tito
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.