Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates gevent to new python3 recipe #1600

Merged
merged 1 commit into from
Jan 27, 2019

Conversation

AndreMiras
Copy link
Member

Also adds unit tests for checking flags are being cleaned up properly.

@AndreMiras
Copy link
Member Author

Depends on greelet #1603 which should be merged first

AndreMiras added a commit to AndreMiras/EtherollApp that referenced this pull request Jan 21, 2019
Also adds unit tests for checking flags are being cleaned up properly.
@AndreMiras AndreMiras force-pushed the feature/gevent_migration branch from 34db3b3 to fd31a66 Compare January 27, 2019 17:27
@AndreMiras
Copy link
Member Author

Conditional build is failing because of permission issues in the Docker env while symlinking, see part of the trace:

  File "/home/user/pythonforandroid/recipe.py", line 979, in build_arch
    self.build_cython_components(arch)
  File "/home/user/pythonforandroid/recipes/gevent/__init__.py", line 23, in build_cython_components
    shprint(sh.ln, '-sf', link_c + '.so', link_rt + '.so')
  File "/home/user/pythonforandroid/logger.py", line 178, in shprint
    for line in output:
  File "/home/user/venv/local/lib/python2.7/site-packages/sh.py", line 863, in next
    self.wait()
  File "/home/user/venv/local/lib/python2.7/site-packages/sh.py", line 792, in wait
    self.handle_command_exit_code(exit_code)
  File "/home/user/venv/local/lib/python2.7/site-packages/sh.py", line 815, in handle_command_exit_code
    raise exc
sh.ErrorReturnCode_1: 
  RAN: /bin/ln -sf /opt/android/android-ndk-r17c/platforms/android-21/arch-arm/usr/lib/libc.so /opt/android/android-ndk-r17c/platforms/android-21/arch-arm/usr/lib/librt.so
  STDOUT:
/bin/ln: failed to create symbolic link '/opt/android/android-ndk-r17c/platforms/android-21/arch-arm/usr/lib/librt.so': Permission denied

This is very specific to our Docker setup since the NDK is installed in /opt/android and requires super privilege to add the temporary symlink.
I think we're still safe to merge nonetheless since prior version of the recipe won't even compile with recent p4a refactoring

@inclement inclement merged commit 041199b into kivy:master Jan 27, 2019
@inclement
Copy link
Member

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants