Minor fixes to basic common bootstrap handling code #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Edit: addressed, see below |
ghost
mentioned this pull request
|
Okay, I have modified this as per @kollivier 's suggestion with the accepted caveat that if a Then I tested that the resulting merge request as it is now works fine and builds my app with no problems, and it does! Travis is also happy. Therefore, as far as I'm concerned, this is ready for merge. |
ghost
changed the title
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes to basic common bootstrap handling code as suggested by @AndreMiras here: #1496 (see the code review comments)
Please note I added
normpathwithout replacing the two code lines after it as suggested in the code review, since that one does something different (not a path normalization, but ensures it is a relative path) and I'm pretty sure it needs to stay in.Tested, ready for merge