Fixes audiostream recipe on Python3 #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With kivy/audiostream#24 that is been merged, now for me it's ok to merge also this recipe. |
AndreMiras
reviewed
Nov 30, 2018
|
|
||
| env['CFLAGS'] += ' -I{jni_path}/{sdl_include}/include -I{jni_path}/{sdl_mixer_include}'.format( | ||
| jni_path=join(self.ctx.bootstrap.build_dir, 'jni'), | ||
| sdl_include=sdl_include, | ||
| sdl_mixer_include=sdl_mixer_include) | ||
| env['NDKPLATFORM'] = self.ctx.ndk_platform | ||
| env['LIBLINK'] = 'NOTNONE' |
There was a problem hiding this comment.
Can you tell us about that line?
There was a problem hiding this comment.
Audiostream setup.py checks for env variable 'LIBLINK' in order to set android as build target.
AndreMiras
previously approved these changes
Nov 30, 2018
There was a problem hiding this comment.
Thanks for the PR!
It's already an improvement over what we had before so I'm in for the merge.
Can you simply address that minor question regarding the LIBLINK environment variable?
If some code comment could help future maintainer to understand why is this, feel free to add it 😉
AndreMiras
approved these changes
Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds python3 support to audiostream recipe.
Before merging we need to merge kivy/audiostream#24 .