Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of file paths in module dependencies #1489

Merged
merged 1 commit into from Nov 26, 2018
Merged

Fix handling of file paths in module dependencies #1489

merged 1 commit into from Nov 26, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 23, 2018

This fixes the handling of file paths in module dependencies as specified with --requirements, which previously led to them simply being ignored (and hence breaking any build that would try to use this).

@ghost
Copy link
Author

ghost commented Nov 23, 2018

This is by the way rather relevant to work around #1488 (because you can copy your project folder and specify that as a dep to make sure it's setup.py installed) so it's not quite as theoretical as it may sound like

@inclement
Copy link
Member

Seems fine, although I'll note that this it not so much fixing the handling of file paths as adding support for modules supplied as file paths. I don't think this has ever been intended to work. It's interesting that it takes so little work to get it going.

@ghost
Copy link
Author

ghost commented Nov 23, 2018

@inclement I can't rule out other broken corner cases, but it worked fine in my tests. Please note this doesn't fix recipe's not handling them though, it just fixes them not working properly for --requirements

@ghost ghost changed the title Fix handling of file paths in module dependencies [WIP] Fix handling of file paths in module dependencies Nov 26, 2018
@ghost ghost changed the title [WIP] Fix handling of file paths in module dependencies Fix handling of file paths in module dependencies Nov 26, 2018
@ghost
Copy link
Author

ghost commented Nov 26, 2018

Updated the code a little such that it leaves URLs alone. Other than that, it works for me, and I encourage others to give it a try. I am depending on an increasing pile of unmerged changes to get my project to build, so it'd be neat to see particularly this file path support go in some time soon

@AndreMiras AndreMiras merged commit a5c9078 into kivy:master Nov 26, 2018
@ghost ghost deleted the fixfilepaths branch November 26, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants