Fixes and clarifies services auto-restart #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Fixes services auto-restart introduced in kivy#643: `onTaskRemoved()` stops the service gracefully using `stopSelf()` when it gets killed. That way `onDestroy()` gets triggered and service will restart under different process if auto-restart is enabled. 2) Documents process behavior and auto-restart usage: Emphasis that services are running in a dedicated processes, different from the app process, which is not the Android default behavior. Adds a code snippet.
|
Build is green ✔️ |
inclement
approved these changes
Sep 15, 2018
|
Seems a clear improvement, thanks :) |
AndreMiras
added a commit
to AndreMiras/EtherollApp
that referenced
this pull request
Sep 15, 2018
Uses `Service.setAutoRestartService()` to restart service when killed, refs kivy/python-for-android#1374
AndreMiras
added a commit
to AndreMiras/EtherollApp
that referenced
this pull request
Sep 15, 2018
Uses `Service.setAutoRestartService()` to restart service when killed, refs kivy/python-for-android#1374
This was referenced Apr 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes services auto-restart introduced in add sticky services, auto-restart services, fix foreground option #643:
onTaskRemoved()stops the service gracefully usingstopSelf()whenit gets killed. That way
onDestroy()gets triggered and service willrestart under different process if auto-restart is enabled.
Documents process behavior and auto-restart usage:
Emphasis that services are running in a dedicated processes, different
from the app process, which is not the Android default behavior.
Adds a code snippet.