Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sympy recipe #1236

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Added sympy recipe #1236

merged 2 commits into from
Dec 14, 2018

Conversation

inclement
Copy link
Member

No description provided.

@inclement
Copy link
Member Author

I made this recipe ages ago, but I think I found a better way to fix the unicode thing, looking into it.

@AndreMiras
Copy link
Member

Looking good to me, I've just added a minor comment

AndreMiras
AndreMiras previously approved these changes Nov 11, 2018
version = '1.1.1'
url = 'https://github.com/sympy/sympy/releases/download/sympy-{version}/sympy-{version}.tar.gz'

# depends = [('python2', 'python3crystax'), 'setuptools']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: I think we can drop that commented code

@AndreMiras AndreMiras dismissed their stale review November 11, 2018 17:39

Travis is failing with Please install the mpmath package with a version >= 0.19

@AndreMiras
Copy link
Member

Looks like this is not compiling, Travis fails with:

Please install the mpmath package with a version >= 0.19

inclement and others added 2 commits December 14, 2018 22:49
Also adds sympy to ignore list:
```
Please install the mpmath package with a version >= 0.19
```
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed linter and added sympy to skip recipe list for the conditional build

@AndreMiras AndreMiras merged commit ea9f346 into kivy:master Dec 14, 2018
@Ohadforman
Copy link

How can I add Please install the mpmath package with a version >= 0.19 to ignore list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants