Fixes for NDK 15+ #1103
Fixes for NDK 15+ #1103
Conversation
https://android.googlesource.com/platform/ndk/+/ndk-r15-release/docs/UnifiedHeaders.md - adds --isysroot and -isystem options for unified header includes - changes --sysroot to use the prebuilt NDK /sysroot
…ompletely clueless about -isysroot and -isystem so it can't link. It traps the sh.make failure and then manually links and installs libffi.so
Discussed here regarding Python3 This patch stuffs the configure setting into the environment to disable the search for langinfo.h
… to drop header files for linking with shared libraries.
…droid into dotnetslash-ndk-15
This lets the python_shared dependency work.
This seems to be necessary with the ndk 15 changes, otherwise some object files can't be linked. It seems like this should be fixable with an LDFLAG, but I can't any changes here that would have broken it.
|
This seems ready for merging to me, but testing would be appreciated. I've tried with the NDK r11c, r15c, and current CrystaX NDK. |
|
It looks like this breaks sqlite3, the same way as described at android/ndk#332 . Looking into it. |
|
I think I'll also test this with NDK 16 (currently beta1 is available) before merging, as this removes the old platform headers. That should expose any issues with still using the old headers (edit: and I'm sure such issues exist!) |
The changes are the same as the patch at https://hg.libsdl.org/SDL_image/rev/7ad06019831d, but modified for version 2.0.1.
|
Everything seems to be working now, including with the NDK 16 beta1. I've run quite a few tests using NDK r11c, r15c, r16-beta1 and crystax, and they all seem to work, so let's go ahead and merge. |
|
How Adding -D_FILE_OFFSET_BITS=32 solves the issue ? |
|
@astha-garg123 I found information about this at android/ndk#332. |
This includes the main changes of @dotnetslash from #1095, plus some further fixes that I needed to get builds working.
Not for merging yet, still checking at least one thing.