Added support for Python 3.6 #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be working now - Python 3.6 will only work for the archs armeabi and armeabi-v7a that I precompiled, but other that it seems to run fine. I'll be looking at improving the python build to let python be built locally in the near future. In the meantime, it would be useful if anyone were able to test this before I merge it. |
|
I haven't had any python 3.6 related error reports after deploying an app with this, so I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not for merging yet.This PR removes some final references to python3.5 to make everything generic, so that python3.6 can be used by adding
python3crystax=3.6in the requirements (the default remains 3.5 for now).This won't actually do anything yet as CrystaX doesn't come with a prebuilt Python 3.6, but I've got this working as well. I'll add support for downloading a prebuilt one that I've generated, or for building a new one locally, shortly.