-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building python2 for armeabi fails due to unknown option "-single_module" (OS X) #623
Comments
Looks like it's trying to build the OSX dylib, which won't work with the Android compiler (obviously). I'm pretty sure that OSX has had the least amount of testing for the p4a revamp. |
I guess it would make sense to use travis for p4a too right? |
Do you mean use Travis to check for these issues? My primary concern there would be the build time required to check everything. Maybe if it could be set up to run once a night rather than whenever a commit happens - won't get immediate results, but issues would still be detected. But mostly I think the revamp just hasn't been tested well in OSX, not that there is any regression. If you mean to use Travis to do your p4a builds though, that would absolutely work. These are only issues in OSX and everything builds fine in Linux. :) |
Should the two patches with the |
Yeah I meant to setup travis to continuously check for build issues. We can use something like nightli.es for this. Or any alternative mentioned here. |
Let's move the CI discussion to #625. |
@inclement Yeah, those should probably be |
@cbenhagen Could you test this please? On these two lines, change |
👍 It compiles. Thank you very much! |
This is not related to #622. I hotfixed this issue by setting:
The text was updated successfully, but these errors were encountered: