Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to build pure Python module included after twisted #337

Closed
jxai opened this issue Mar 14, 2015 · 6 comments
Closed

Failed to build pure Python module included after twisted #337

jxai opened this issue Mar 14, 2015 · 6 comments

Comments

@jxai
Copy link
Contributor

jxai commented Mar 14, 2015

When including a pure Python module like rsa right after twisted:

./distribute.sh -m "twisted rsa kivy" -d "test"

Building would eventually fail with following error:

Run pymodules install
We want to install: rsa
Check if /usr/local/bin/virtualenv is present
Check if a virtual environment already exists
Installing virtualenv
New python executable in venv/bin/python2.7
Also creating executable in venv/bin/python
Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/bin/python2.7
Create a requirement file for pure-python modules
Install pure-python modules via pip in venv
DEPRECATION: --download-cache has been deprecated and will be removed in the future. Pip now automatically uses and configures its cache.
Collecting rsa (from -r requirements.txt (line 2))
  Using cached rsa-3.1.4.tar.gz
  setuptools must be installed to install from a source distribution

It is quite strange as setuptools was clearly already installed in venv.

@jxai
Copy link
Contributor Author

jxai commented Mar 14, 2015

It turns out that the twisted recipe (and maybe some other recipes) changed PYTHONPATH:

export PYTHONPATH=$SITEPACKAGES_PATH:$BUILDLIB_PATH

which was then mistakenly picked up by venv, leading to the missing setuptools.

Virtualenv should be setup with no PYTHONPATH, a PR will follow.

@jxai jxai mentioned this issue Mar 14, 2015
@FeralBytes
Copy link
Contributor

Were you running P4A in a venv, or are you talking about the venv that P4A creates it's self? I am sure it is the case but just confirm that your PR #338 does actually remedy the issue without causing any side effects?

@jxai
Copy link
Contributor Author

jxai commented Mar 16, 2015

I was talking about the venv created by P4A. AFAIK PR #338 fixed the issue, and I haven't observed side effects so far.

@kived
Copy link
Contributor

kived commented Mar 16, 2015

Can you test that #320 fixes this? Similar problems happen between recipe builds as well, and your fix wouldn't help that.

@FeralBytes
Copy link
Contributor

@jasonxunxu did you ever test #320 as requested by kived?

tito added a commit that referenced this issue May 14, 2015
@tito
Copy link
Member

tito commented May 16, 2015

We'll assume it does. Please reopen if the case still happen.

@tito tito closed this as completed May 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants