Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update conditional build to python3 #1485

Closed
AndreMiras opened this issue Nov 23, 2018 · 0 comments
Closed

Update conditional build to python3 #1485

AndreMiras opened this issue Nov 23, 2018 · 0 comments
Assignees
@AndreMiras
Labels
bug

Comments

@AndreMiras
Copy link
Member

In #1471 we killed crystax for the CI which then means we need to port the conditional build script to python3 see https://github.com/kivy/python-for-android/blob/3e561b0/ci/rebuild_updated_recipes.py#L12

Currently it fails with:

Traceback (most recent call last):
  File "./ci/rebuild_updated_recipes.py", line 99, in <module>
    main()
  File "./ci/rebuild_updated_recipes.py", line 95, in main
    build(target_python, recipes)
  File "./ci/rebuild_updated_recipes.py", line 59, in build
    crystax_ndk_home = os.environ['CRYSTAX_NDK_HOME']
  File "/home/user/venv/lib/python2.7/UserDict.py", line 40, in __getitem__
    raise KeyError(key)
KeyError: 'CRYSTAX_NDK_HOME'

e.g. https://api.travis-ci.org/v3/job/458635355/log.txt
@AndreMiras AndreMiras added the bug label Nov 23, 2018
@ghost ghost mentioned this issue Nov 23, 2018
Merged
@AndreMiras AndreMiras mentioned this issue Dec 4, 2018
Merged
@AndreMiras AndreMiras self-assigned this Dec 10, 2018
AndreMiras added a commit to AndreMiras/python-for-android that referenced this issue Dec 10, 2018
@AndreMiras
Uses target python3 on conditional buids, fixes kivy#1485
47b4cac 
`python3crystax` support was removed from the CI in kivy#1471.
Conditional builds now relies on `python3` with fallback to `python2`.

Adds `python3` support to `jedi` recipe to demonstrate.
inclement added a commit that referenced this issue Dec 12, 2018
@inclement
Merge pull request #1515 from AndreMiras/feature/ticket1485_condition…
8bf9651 
…al_build_via_python3

Uses target python3 on conditional buids, fixes #1485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreMiras AndreMiras

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndreMiras