Skip to content

Commit

Permalink
use shell as default for argparse. modified template to not use
Browse files Browse the repository at this point in the history 
android_api at all.
  • Loading branch information
@knappador
knappador committed Jun 18, 2014
1 parent 08b959e commit aa38c6b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/build.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ def make_package(args):
# Update the project to a recent version.
try:
subprocess.call([ANDROID, 'update', 'project', '-p', '.', '-t',
'android-{}'.format(args['sdk_version'])])
'android-{}'.format(args.sdk_version)])
except (OSError, IOError):
print 'An error occured while calling', ANDROID, 'update'
print 'Your PATH must include android tools.'
Expand Down
4 changes: 2 additions & 2 deletions src/templates/AndroidManifest.tmpl.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
android:normalScreens="true"
android:largeScreens="true"
android:anyDensity="true"
{% if android_api >= 9 %}
{% if args.min_sdk_version >= 9 %}
android:xlargeScreens="true"
{% endif %}
/>
Expand All @@ -29,7 +29,7 @@

<activity android:name="org.renpy.android.PythonActivity"
android:label="@string/iconName"
android:configChanges="mcc|mnc|locale|touchscreen|keyboard|keyboardHidden|navigation|orientation|screenLayout|fontScale|uiMode{% if android_api >= 13 %}|screenSize{% endif %}"
android:configChanges="mcc|mnc|locale|touchscreen|keyboard|keyboardHidden|navigation|orientation|screenLayout|fontScale|uiMode{% if args.min_sdk_version >= 13 %}|screenSize{% endif %}"
android:launchMode="singleTask"
android:process=":python"
android:screenOrientation="{{ args.orientation }}"
Expand Down

1 comment on commit aa38c6b

@sladinji
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

With this change :
...{% if android_api >= 13 %}|screenSize{% endif %}"
...{% if args.min_sdk_version >= 13 %}|screenSize{% endif %}"

I must turn min api version to 13 if i want my app working with screen rotate, this should be :

{% if args.sdk_version >= 13 %}|screenSize{% endif %}"

Please sign in to comment.