Optimize Dockerfile

Prioritize SDK and NDK downloads before everything because once downloaded we don't care about redownloading unless the version is changed and layer cache works this way more efficiently. Redirect Licenses to /dev/null, move more important layers up. Move '&&' operators to the front - Docker sometimes, (personally I've encountered it only with apt and old coreutils), is very critical of the amount of spaces *after* the operator but does not care what's in front of it that much.
kivy · Nov 18, 2018 · 202ff8a · 202ff8a
1 parent 5d4c974
commit 202ff8a
Showing 1 changed file with 86 additions and 46 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,82 +1,122 @@
 # Dockerfile with:
 #   - Android build environment
 #   - python-for-android dependencies
+#
 # Build with:
-# docker build --tag=p4a .
+#     docker build --tag=p4a .
+#
 # Run with:
-# docker run p4a /bin/sh -c '. venv/bin/activate && p4a apk --help'
+#     docker run -it --rm p4a /bin/sh -c '. venv/bin/activate && p4a apk --help'
+#
 # Or for interactive shell:
-# docker run -it --rm p4a
+#     docker run -it --rm p4a
+#
+# Note:
+#     Use 'docker run' without '--rm' flag for keeping the container and use
+#     'docker commit <container hash> <new image>' to extend the original image
+
 FROM ubuntu:18.04
 
+ENV ANDROID_HOME="/opt/android"
+
+
+ENV ANDROID_NDK_HOME="${ANDROID_HOME}/android-ndk"
+ENV ANDROID_NDK_HOME_V="${ANDROID_NDK_HOME}-r${ANDROID_NDK_VERSION}"
 
-ENV USER="user"
-ENV HOME_DIR="/home/${USER}"
-ENV WORK_DIR="${HOME_DIR}" \
-    PATH="${HOME_DIR}/.local/bin:${PATH}"
 # get the latest version from https://developer.android.com/ndk/downloads/index.html
 ENV ANDROID_NDK_VERSION="16b"
-# get the latest version from https://developer.android.com/studio/index.html
-ENV ANDROID_SDK_TOOLS_VERSION="3859397"
+ENV ANDROID_NDK_ARCHIVE="android-ndk-r${ANDROID_NDK_VERSION}-linux-x86_64.zip"
+ENV ANDROID_NDK_DL_URL="https://dl.google.com/android/repository/${ANDROID_NDK_ARCHIVE}"
 
-ENV ANDROID_HOME="/opt/android"
-ENV ANDROID_NDK_HOME="${ANDROID_HOME}/android-ndk" \
-    ANDROID_SDK_HOME="${ANDROID_HOME}/android-sdk"
-ENV ANDROID_NDK_HOME_V="${ANDROID_NDK_HOME}-r${ANDROID_NDK_VERSION}" \
-ENV ANDROID_NDK_ARCHIVE="android-ndk-r${ANDROID_NDK_VERSION}-linux-x86_64.zip" \
-    ANDROID_SDK_TOOLS_ARCHIVE="sdk-tools-linux-${ANDROID_SDK_TOOLS_VERSION}.zip"
-ENV ANDROID_NDK_DL_URL="https://dl.google.com/android/repository/${ANDROID_NDK_ARCHIVE}" \
-    ANDROID_SDK_TOOLS_DL_URL="https://dl.google.com/android/repository/${ANDROID_SDK_TOOLS_ARCHIVE}"
+RUN apt update -qq \
+    && apt install -qq --yes --no-install-recommends curl \
+    && rm -rf /var/lib/apt/lists/*
 
-# install system dependencies
-RUN apt update -qq && apt install -qq --yes --no-install-recommends \
-    python virtualenv python-pip wget curl lbzip2 patch bsdtar sudo && \
-    rm -rf /var/lib/apt/lists/*
+# download and install Android NDK
+RUN curl --location --progress-bar \
+        "${ANDROID_NDK_DL_URL}" \
+        --output "${ANDROID_NDK_ARCHIVE}" \
+    && mkdir --parents "${ANDROID_NDK_HOME_V}" \
+    && unzip -q "${ANDROID_NDK_ARCHIVE}" -d "${ANDROID_HOME}" \
+    && ln -sfn "${ANDROID_NDK_HOME_V}" "${ANDROID_NDK_HOME}" \
+    && rm -rf "${ANDROID_NDK_ARCHIVE}"
 
-# build dependencies
-# https://buildozer.readthedocs.io/en/latest/installation.html#android-on-ubuntu-16-04-64bit
-RUN dpkg --add-architecture i386 && apt update -qq && apt install -qq --yes --no-install-recommends \
-    build-essential ccache git libncurses5:i386 libstdc++6:i386 libgtk2.0-0:i386 \
-    libpangox-1.0-0:i386 libpangoxft-1.0-0:i386 libidn11:i386 python2.7 python2.7-dev \
-    openjdk-8-jdk zip unzip zlib1g-dev zlib1g:i386
 
-# specific recipes dependencies (e.g. libffi requires autoreconf binary)
-RUN apt install -qq --yes --no-install-recommends \
-    autoconf automake cmake gettext libltdl-dev libtool pkg-config && \
-    rm -rf /var/lib/apt/lists/*
+ENV ANDROID_SDK_HOME="${ANDROID_HOME}/android-sdk"
 
-# download and install Android NDK
-RUN curl --location --progress-bar "${ANDROID_NDK_DL_URL}" --output "${ANDROID_NDK_ARCHIVE}" && \
-    mkdir --parents "${ANDROID_NDK_HOME_V}" && \
-    unzip -q "${ANDROID_NDK_ARCHIVE}" -d "${ANDROID_HOME}" && \
-    ln -sfn "${ANDROID_NDK_HOME_V}" "${ANDROID_NDK_HOME}" && \
-    rm -rf "${ANDROID_NDK_ARCHIVE}"
+# get the latest version from https://developer.android.com/studio/index.html
+ENV ANDROID_SDK_TOOLS_VERSION="3859397"
+ENV ANDROID_SDK_TOOLS_ARCHIVE="sdk-tools-linux-${ANDROID_SDK_TOOLS_VERSION}.zip"
+ENV ANDROID_SDK_TOOLS_DL_URL="https://dl.google.com/android/repository/${ANDROID_SDK_TOOLS_ARCHIVE}"
 
 # download and install Android SDK
-RUN curl --location --progress-bar "${ANDROID_SDK_TOOLS_DL_URL}" --output "${ANDROID_SDK_TOOLS_ARCHIVE}" && \
-    mkdir --parents "${ANDROID_SDK_HOME}" && \
-    unzip -q "${ANDROID_SDK_TOOLS_ARCHIVE}" -d "${ANDROID_SDK_HOME}" && \
-    rm -rf "${ANDROID_SDK_TOOLS_ARCHIVE}"
+RUN curl --location --progress-bar \
+        "${ANDROID_SDK_TOOLS_DL_URL}" \
+        --output "${ANDROID_SDK_TOOLS_ARCHIVE}" \
+    && mkdir --parents "${ANDROID_SDK_HOME}" \
+    && unzip -q "${ANDROID_SDK_TOOLS_ARCHIVE}" -d "${ANDROID_SDK_HOME}" \
+    && rm -rf "${ANDROID_SDK_TOOLS_ARCHIVE}"
 
 # update Android SDK, install Android API, Build Tools...
-RUN mkdir --parents "${ANDROID_SDK_HOME}/.android/" && \
-    echo '### User Sources for Android SDK Manager' > "${ANDROID_SDK_HOME}/.android/repositories.cfg"
-RUN yes | "${ANDROID_SDK_HOME}/tools/bin/sdkmanager" --licenses
+RUN mkdir --parents "${ANDROID_SDK_HOME}/.android/" \
+    && echo '### User Sources for Android SDK Manager' \
+        > "${ANDROID_SDK_HOME}/.android/repositories.cfg"
+
+# accept Android licenses
+RUN yes | "${ANDROID_SDK_HOME}/tools/bin/sdkmanager" --licenses >> /dev/null
+
+# download platforms, API, build tools
 RUN "${ANDROID_SDK_HOME}/tools/bin/sdkmanager" "platforms;android-19" && \
     "${ANDROID_SDK_HOME}/tools/bin/sdkmanager" "platforms;android-27" && \
     "${ANDROID_SDK_HOME}/tools/bin/sdkmanager" "build-tools;26.0.2" && \
     chmod +x "${ANDROID_SDK_HOME}/tools/bin/avdmanager"
 
+
+ENV USER="user"
+ENV HOME_DIR="/home/${USER}"
+ENV WORK_DIR="${HOME_DIR}" \
+    PATH="${HOME_DIR}/.local/bin:${PATH}"
+
+# install system dependencies
+RUN apt update -qq \
+    && apt install -qq --yes --no-install-recommends \
+        python virtualenv python-pip wget curl lbzip2 patch bsdtar sudo \
+    && rm -rf /var/lib/apt/lists/*
+
+# build dependencies
+# https://buildozer.readthedocs.io/en/latest/installation.html#android-on-ubuntu-16-04-64bit
+RUN dpkg --add-architecture i386 \
+    && apt update -qq \
+    && apt install -qq --yes --no-install-recommends \
+        build-essential ccache git python2.7 python2.7-dev \
+        libncurses5:i386 libstdc++6:i386 libgtk2.0-0:i386 \
+        libpangox-1.0-0:i386 libpangoxft-1.0-0:i386 libidn11:i386 \
+        openjdk-8-jdk zip unzip zlib1g-dev zlib1g:i386
+
+# specific recipes dependencies (e.g. libffi requires autoreconf binary)
+RUN apt install -qq --yes --no-install-recommends \
+        autoconf automake cmake gettext libltdl-dev libtool pkg-config \
+    && rm -rf /var/lib/apt/lists/*
+
+
 # prepare non root env
 RUN useradd --create-home --shell /bin/bash ${USER}
+
 # with sudo access and no password
 RUN usermod -append --groups sudo ${USER}
 RUN echo "%sudo ALL=(ALL) NOPASSWD: ALL" >> /etc/sudoers
-RUN pip install --quiet --upgrade cython==0.28.6
+
+
+RUN pip install --upgrade cython==0.28.6
+
 WORKDIR ${WORK_DIR}
 COPY . ${WORK_DIR}
+
 # user needs ownership/write access to these directories
 RUN chown --recursive ${USER} ${WORK_DIR} ${ANDROID_SDK_HOME}
 USER ${USER}
+
 # install python-for-android from current branch
-RUN virtualenv --python=python venv && . venv/bin/activate && pip install --quiet -e .
+RUN virtualenv --python=python venv \
+    && . venv/bin/activate \
+    && pip install -e .