Keyword should only hold name of license #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In accordance with pypa/twine#425
|
Good call, but the name of the license is "MIT" not "LICENSE", but if you change that, i think the PR should be accepted. |
tshirtman
reviewed
Aug 28, 2022
|
Whoops, that makes more sense. Thanks for the review @tshirtman! |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with pypa/twine#425,
licensekeyword should not hold a multi-line file but rather simply be the name for the license.Could be potential fix for #698 where raw Markdown is being displayed on PyPI. I am definitely interested in working for a fix for #698 but would appreciate some guidance in where to start as I am more of a beginner.