Added Vibrator facade and android implementation #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def exists(self): | ||
| '''Check if the device has a vibrator. Returns True or False.''' | ||
| return self._exists() |
There was a problem hiding this comment.
On platforms without a vibrator, this returns NotImplementedError when it should return False. This makes the example app crash on those platforms, instead of failing gracefully.
|
I don't feel very strongly about this, but I think the current way is consistent with the rest of plyer - actually I think it's in general maybe a bit annoying that a user has to potentially handle NotImplementedError. I think a consistent solution would be to simply implement the desktop facades, and have them return False from everything. That way NotImplemented really does mean not implemented, but the desktop still has the right behaviour...would that suit you? |
inclement
added a commit
that referenced
this pull request
Mar 16, 2014
Added Vibrator facade and android implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.