Add extra options for installation via setuptools #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref 3892b41#r29926423, but we still need pyobjus released and for that we need |
|
Last step is waiting for merge + release, ref kivy/pyobjus#45. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More comfortable than using
try/exceptand shut the user down with a warning. Instead we should provide an interface to install the conditional requirement, i.e. in this casepyjniusfor Android platform andpyobjusfor macOS/iOS.Choosing non-intrusive installation option because it might break stuff for mobile platforms if enforcing the requirements on pyobjus/pyjnius + there are no releases of pyobjus/pyjnius yet (wip), therefore:
will for now just crash. The
devoption will work though.