Fix test_facade failing for Py3 by switching to Mocks #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessant
requested review from
dessant
and removed request for
akshayaurora and
dessant
dessant
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach used dynamically created files and imported each
Dummyclass from separate platform. That didn't work for OSX + Py3 and apparently had problems even on GNU/Linux + Py3 sometimes. Somehow it seems to me qua-non's idea about relative imports had something to do with it because I calledreload()in the test.I switched to dynamically created modules and mocked
__import__instead, which seems to work + simplified the tests for each platform into a single one.