Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in WindowsBalloonTip #343

Merged
merged 1 commit into from
Jun 18, 2017
Merged

Fix bug in WindowsBalloonTip #343

merged 1 commit into from
Jun 18, 2017

Conversation

Chronial
Copy link
Contributor

@Chronial Chronial commented Jun 17, 2017

icon_path_name is not defined. So passing an invalid icon file will raise an error about that instead of the expected Exception:

Traceback (most recent call last):
  File ".\win-popup.py", line 6, in <module>
    app_name='sync-seedbox', timeout=10)
  File "C:\Tools\Python35\lib\site-packages\plyer\platforms\win\libs\balloontip.py", line 145, in balloon_tip
    WindowsBalloonTip(**kwargs)
  File "C:\Tools\Python35\lib\site-packages\plyer\platforms\win\libs\balloontip.py", line 91, in __init__
    format(icon_path_name))
NameError: name 'icon_path_name' is not defined

@KeyWeeUsr KeyWeeUsr merged commit ecea808 into kivy:master Jun 18, 2017
@KeyWeeUsr
Copy link
Contributor

@Chronial Thanks! It's basically from 1d7fb1f where the name was removed, but apparently not updated(typo). The else part of that block should load just the default application icon:

IDI_APPLICATION MAKEINTRESOURCE(32512) | Default application icon.
(source)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants